Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] Support TI_EMSCRIPTENED option as an env var (JS 3/n) #4106

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

AmesingFlank
Copy link
Collaborator

Related issue = #3781

This PR makes it more convenient to turn on TI_EMSCRIPTENED.

Now you can do TI_EMSCRIPTENED=1 python setup.py develop --user, so that you won't have to edit the TAICHI_CMAKE_ARGS variable.

@vercel
Copy link

vercel bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/7QkfeH4D79SQDsYuFoMihrr8ordh
✅ Preview: Canceled

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 25c5d22

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ef417553c0820007cc9037

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit b036161 into taichi-dev:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants