-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metal] Give random seeds a unique value #4206
Conversation
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: f9de219 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f78d241fa65f00071498b2 |
/format |
@@ -110,6 +124,28 @@ class RootIdsExtractor : public BasicStmtVisitor { | |||
std::unordered_set<int> roots_; | |||
}; | |||
|
|||
class TaskPreprocessor final : public BasicStmtVisitor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we collect this into a analysis pass? (i.e. dump out usage and capability information, like random, numerical types used, SNode types used, external arrays, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this is very useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Related issue = #4197