Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal] Give random seeds a unique value #4206

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jan 31, 2022

Related issue = #4197

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: f9de219

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f78d241fa65f00071498b2

@k-ye
Copy link
Member Author

k-ye commented Jan 31, 2022

/format

@k-ye k-ye requested review from bobcao3 and ailzhang February 1, 2022 00:23
@@ -110,6 +124,28 @@ class RootIdsExtractor : public BasicStmtVisitor {
std::unordered_set<int> roots_;
};

class TaskPreprocessor final : public BasicStmtVisitor {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we collect this into a analysis pass? (i.e. dump out usage and capability information, like random, numerical types used, SNode types used, external arrays, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this is very useful!

Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@ailzhang ailzhang merged commit f8e93cf into taichi-dev:master Feb 8, 2022
@k-ye k-ye deleted the mtl-rand-seeds branch February 25, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants