-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vulkan] Test & build macOS 10.15 MoltenVK #4259
Conversation
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 799b752 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62082f8dcf19f8000722d113 😎 Browse the preview: https://deploy-preview-4259--docsite-preview.netlify.app |
Tests are not run, as the Azure runner does not have Metal
/format |
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
VkPhysicalDeviceProperties properties{}; | ||
vkGetPhysicalDeviceProperties(physical_device, &properties); | ||
|
||
TI_INFO("Found Vulkan Device {} ({})", i, properties.deviceName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TI_INFO("Found Vulkan Device {} ({})", i, properties.deviceName); | |
TI_DEBUG("Found Vulkan Device {} ({})", i, properties.deviceName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in conjunction with #4255 so that the user can know which device corresponds to which ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe is there a way to display info without including the source file path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related issue = #