[mac] Fix external_func test failures on arm backend #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests failed on my M1 mac when building from source. It passed CI machine mainly because the tests were skipped due to https://github.com/taichi-dev/taichi/blob/master/tests/python/test_external_func.py#L13. We actually limit external_func to `x64` backend not `cpu`. (Although I've tried on arm64 and it worked, I'll leave enabling it on arm64 to a separate PR)
✅ Deploy Preview for docsite-preview canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests failed on my M1 mac when building from source. It passed CI
machine mainly because the tests were skipped due to
https://github.com/taichi-dev/taichi/blob/master/tests/python/test_external_func.py#L13.
We actually limit external_func to
x64backend notcpu.(Although I've tried on arm64 and it worked, I'll leave enabling it on
arm64 to a separate PR)
Related issue = #