Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Enable shared array support for vulkan backend #5583

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

turbo0628
Copy link
Member

@turbo0628 turbo0628 commented Aug 1, 2022

closes #5338

This PR enables shared array support for vulkan backend but is only stable with vk_api_version="1.0" due to a memory barrier problem.

Will open another issue to fix the problem.

@turbo0628 turbo0628 requested a review from bobcao3 August 1, 2022 03:28
@netlify
Copy link

netlify bot commented Aug 1, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 433b293
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62e7486e102cba000888766e
😎 Deploy Preview https://deploy-preview-5583--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@PENGUINLIONG PENGUINLIONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@turbo0628 turbo0628 merged commit 50cc1e3 into taichi-dev:master Aug 1, 2022
@turbo0628 turbo0628 deleted the spirv_shared_array branch August 1, 2022 09:27
@turbo0628 turbo0628 restored the spirv_shared_array branch August 1, 2022 09:27
@turbo0628 turbo0628 deleted the spirv_shared_array branch August 1, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Perf] Shared Array APIs
2 participants