Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Support basic sparse matrix operations on GPU. #6082

Merged
merged 25 commits into from
Sep 22, 2022

Conversation

Hanke98
Copy link
Collaborator

@Hanke98 Hanke98 commented Sep 16, 2022

Issue: #2906

Implement the basic operations like +, -, *, @, and transpose, etc. in this pr.

@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 64633b9
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/632c4ffab42dea0008b92ec0
😎 Deploy Preview https://deploy-preview-6082--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taichi-gardener taichi-gardener added this to In progress in Lang Features & Python Sep 16, 2022
@Hanke98
Copy link
Collaborator Author

Hanke98 commented Sep 18, 2022

By far, I have implement +(with the help of @FantasyVR ), -, @, transpose and multiplication with float. However, I didn’t find the correct routine for element-wise multiplication. It seems that element-wise multiplication is not a very common usage of sparse matrix. Do you have any advice? @FantasyVR

@FantasyVR
Copy link
Collaborator

Thanks @Hanke98, I also didn't find any Cusparse API for computing element-wise multiplication. Maybe we could let it be right now and figure it out later.

@Hanke98
Copy link
Collaborator Author

Hanke98 commented Sep 19, 2022

Thanks @Hanke98, I also didn't find any Cusparse API for computing element-wise multiplication. Maybe we could let it be right now and figure it out later.

OK, thanks! Then let me add some tests and please have a reviewer later :-)

@Hanke98 Hanke98 marked this pull request as ready for review September 21, 2022 01:18
Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you check the failed CI test?

Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits.

taichi/program/sparse_matrix.cpp Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Outdated Show resolved Hide resolved
taichi/program/sparse_matrix.h Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Outdated Show resolved Hide resolved
@strongoier strongoier merged commit f253cac into taichi-dev:master Sep 22, 2022
Lang Features & Python automation moved this from In progress to Done Sep 22, 2022
FantasyVR pushed a commit that referenced this pull request Nov 7, 2022
Issue: #2906 #6082 

+ Support element access for sparse matrix on GPU.
+ Add tests for GPU sparse matrix operators.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yi Xu <xy_xuyi@foxmail.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#2906 taichi-dev#6082 

+ Support element access for sparse matrix on GPU.
+ Add tests for GPU sparse matrix operators.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yi Xu <xy_xuyi@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants