Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Add element access for sparse matrix on CUDA #6250

Merged
merged 16 commits into from
Nov 7, 2022

Conversation

Hanke98
Copy link
Collaborator

@Hanke98 Hanke98 commented Oct 9, 2022

Issue: #2906 #6082

  • Support element access for sparse matrix on GPU.
  • Add tests for GPU sparse matrix operators.

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 1766349
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/636872d9815d850008e9133e
😎 Deploy Preview https://deploy-preview-6250--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taichi-gardener taichi-gardener added this to In progress in Lang Features & Python Oct 9, 2022
@Hanke98 Hanke98 marked this pull request as ready for review October 9, 2022 08:57
@Hanke98 Hanke98 requested a review from FantasyVR October 9, 2022 08:57
Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

tests/python/test_sparse_matrix.py Show resolved Hide resolved
@Hanke98 Hanke98 force-pushed the impl-gpu-spm-elem-get branch 4 times, most recently from 675885f to 4f90e5d Compare November 2, 2022 02:55
@Hanke98
Copy link
Collaborator Author

Hanke98 commented Nov 2, 2022

Finally, I made every test passed! @FantasyVR @strongoier please have a final review, thanks!

Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

tests/python/test_sparse_matrix.py Outdated Show resolved Hide resolved
misc/test_gpu_sm_op.py Outdated Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Show resolved Hide resolved
Hanke98 and others added 2 commits November 4, 2022 18:42
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FantasyVR FantasyVR merged commit 4079be9 into taichi-dev:master Nov 7, 2022
Lang Features & Python automation moved this from In progress to Done Nov 7, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#2906 taichi-dev#6082 

+ Support element access for sparse matrix on GPU.
+ Add tests for GPU sparse matrix operators.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yi Xu <xy_xuyi@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants