[build] Add MSBuild option to setup.py #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jim19930609
reviewed
Nov 24, 2022
bobcao3
changed the title
jim19930609
reviewed
Nov 28, 2022
ah yes... accidentally merged in the headers cleanup |
ailzhang
approved these changes
Nov 30, 2022
PGZXB
pushed a commit
to PGZXB/taichi
that referenced
this pull request
Dec 5, 2022
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it works flawlessly with scikit-build. We used to only provide Ninja because we roll the build commands ourselves.
Set environment variable TAICHI_USE_MSBUILD to 1 or ON to use MSBuild + MSVC. This will also provide a seamless user experience in Visual Studio.