Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - Editor reloads images on every render #945

Closed
2 of 9 tasks
YuliaTsareva opened this issue Apr 2, 2024 · 5 comments
Closed
2 of 9 tasks

🐞 - Editor reloads images on every render #945

YuliaTsareva opened this issue Apr 2, 2024 · 5 comments
Assignees
Labels
bug Something isn't working P1 This issue has high priority

Comments

@YuliaTsareva
Copy link

Playground Link

No response

Description

How to reproduce:

  1. Open dev tools.
  2. Add image to editor.
  3. Trigger re-render (click on page, scroll it, switch tabs).

There are multiple image requests in Network.

Angular version

15.2.1

Taiga UI version

3.69.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@YuliaTsareva YuliaTsareva added bug Something isn't working state: need triage state need triage labels Apr 2, 2024
@splincode splincode added P1 This issue has high priority and removed state: need triage state need triage labels Apr 2, 2024
@splincode
Copy link
Member

@YuliaTsareva I can't reproduce

Screen.Recording.2024-04-03.at.18.08.22.mp4

@waterplea
Copy link
Contributor

@splincode your example uses base64, of course it will no network requests.
@YuliaTsareva if the DOM is rebuilt and the image tag is recreated — it would re-request the image, unless cache is configured otherwise. That is to be expected. But scroll should not trigger DOM rebuild.

@splincode
Copy link
Member

splincode commented Apr 4, 2024

uses base64, of course it will no network requests. not a problem for other case

Screen.Recording.2024-04-04.at.11.10.51.mp4

in the editor itself images does not re-render

@Ultraviolence322
Copy link

@splincode
Copy link
Member

Fixed by v2.x

@splincode splincode self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 This issue has high priority
Projects
No open projects
Status: 💡 Backlog
Development

No branches or pull requests

4 participants