Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殌 - Add a service for breaking points that matches the current grid #3336

Closed
DerSizeS opened this issue Dec 28, 2022 · 3 comments 路 Fixed by #3806
Closed

馃殌 - Add a service for breaking points that matches the current grid #3336

DerSizeS opened this issue Dec 28, 2022 · 3 comments 路 Fixed by #3806
Assignees
@zarghamkhandev
Labels
community contribution This issue was closed by a PR from the community feature New feature or request P3 This issue has low priority

Comments

@DerSizeS
Copy link

Which @taiga-ui/* package(s) are relevant/releated to the feature request?

core, styles

Description

Add a service for breaking points that matches the current grid. I want to be able to hide and remove elements based on the current grid size.
@splincode splincode added P3 This issue has low priority and removed state: need triage labels Jan 9, 2023
@waterplea waterplea added the contributions welcome Architecture is clear and community can help label Jan 20, 2023
@waterplea
Copy link
Collaborator

Basically it should be an Observable service that uses WINDOW and matchMedia with TUI_MEDIA token to emit current breakpoint.

@zarghamkhandev
Copy link
Contributor

Hi, I have started working on it. Should this service be singleton or there is no need to do so ?

@waterplea
Copy link
Collaborator

Hi, I have started working on it. Should this service be singleton or there is no need to do so ?

Just providedIn: root is fine

@zarghamkhandev zarghamkhandev mentioned this issue Mar 10, 2023
Merged
11 tasks
@waterplea waterplea added community contribution This issue was closed by a PR from the community and removed contributions welcome Architecture is clear and community can help labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zarghamkhandev zarghamkhandev

Labels
community contribution This issue was closed by a PR from the community feature New feature or request P3 This issue has low priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cdk): introduce breakpoint service zarghamkhandev/taiga-ui-fork
4 participants
@DerSizeS @waterplea @splincode @zarghamkhandev