-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk): introduce breakpoint service #3806
feat(cdk): introduce breakpoint service #3806
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (3)
Unchanged files (2)
Total files change +399B +0.06% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
+ Coverage 61.23% 61.27% +0.03%
==========================================
Files 1592 1593 +1
Lines 18818 18836 +18
Branches 2590 2593 +3
==========================================
+ Hits 11523 11541 +18
- Misses 6815 6816 +1
+ Partials 480 479 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bf92e16
to
bd5c797
Compare
@zarghamkhandev just a ping to see if you want this to make Monday's release :) All is missing is the demo page. |
@waterplea I am on it. What I am not able to figure out is, whether I need to create a viewport like UI within the example or ask user to change the actual viewport and just display the current breakpoint. WDYT. |
Just ask to change the actual window size. And place a few DOM elements visible only for particular media configurations through CSS side by side with the same kind of elements hidden with *ngIf and this new service. |
3403b63
to
5a3ce3f
Compare
@waterplea its ready for review |
projects/demo/src/modules/services/breakpoint/examples/inject-service.md
Outdated
Show resolved
Hide resolved
4f37a86
to
0aa6903
Compare
projects/demo/src/modules/services/breakpoint/breakpoint.module.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/cypress/tests/core/breakpoint-service/breakpoint-serivce.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/services/breakpoint/examples/inject-service.md
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/services/breakpoint/examples/1/component.ts
Outdated
Show resolved
Hide resolved
…service.md Co-authored-by: Nikita Barsukov <nikita.s.barsukov@gmail.com>
15f862e
to
a8859d3
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3336
What is the new behavior?
New service has been introduces which emits corresponding TUI_MEIDA key on media query change.
Does this PR introduce a breaking change?