Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): InputYear uses Maskito instead of legacy text-mask #4382

Merged
merged 4 commits into from
May 5, 2023

Conversation

nsbarsukov
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Partially solves #120

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 4, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented May 4, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/vendor.(hash).js
195.43KB (+4.22KB +2.21%) +10%
demo/browser/main.(hash).js
322.93KB (+133B +0.04%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/runtime.(hash).js
37.46KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +4.36KB +0.74%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+4.38KB +0.19%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Visit the preview URL for this PR (updated for commit 3c91b85):

https://taiga-ui--pr4382-maskito-input-year-cdced3vv.web.app

(expires Fri, 05 May 2023 13:46:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.07 ⚠️

Comparison is base (764b007) 61.14% compared to head (3c91b85) 61.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4382      +/-   ##
==========================================
- Coverage   61.14%   61.07%   -0.07%     
==========================================
  Files        1650     1650              
  Lines       19308    19313       +5     
  Branches     2745     2746       +1     
==========================================
- Hits        11805    11796       -9     
- Misses       7015     7029      +14     
  Partials      488      488              
Flag Coverage Δ
addon-charts 74.75% <ø> (ø)
addon-doc 51.41% <ø> (ø)
addon-editor 49.87% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 39.94% <ø> (ø)
core 76.91% <ø> (ø)
kit 72.26% <55.55%> (-0.23%) ⬇️
summary 61.07% <55.55%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/directives/mask/legacy-mask.ts 89.36% <ø> (ø)
.../kit/components/input-year/input-year.component.ts 32.14% <50.00%> (-46.12%) ⬇️
...cts/kit/components/input-year/input-year.module.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov merged commit a3183c8 into main May 5, 2023
44 checks passed
@nsbarsukov nsbarsukov deleted the maskito-input-year branch May 5, 2023 07:04
@well-done-bot
Copy link

well-done-bot bot commented May 5, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants