Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): add tui-avatar-labeled #6523

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the new behaviour?

image

Copy link

lumberjack-bot bot commented Jan 23, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Visit the preview URL for this PR (updated for commit 1ee41fd):

https://taiga-ui--pr6523-splincode-avatar-lab-ngiggtzc.web.app

(expires Thu, 25 Jan 2024 13:13:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 23, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+381.72KB +10%
demo/browser/vendor.(hash).js
+212.98KB +10%
demo/browser/runtime.(hash).js
+39.94KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +647.29KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.33MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@24267dc). Click here to learn what that means.

❗ Current head 8457d8a differs from pull request most recent head 1ee41fd. Consider uploading reports for the commit 1ee41fd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6523   +/-   ##
=======================================
  Coverage        ?   70.56%           
=======================================
  Files           ?     1097           
  Lines           ?    13091           
  Branches        ?     1849           
=======================================
  Hits            ?     9238           
  Misses          ?     3542           
  Partials        ?      311           
Flag Coverage Δ
addon-charts 71.46% <0.00%> (?)
addon-doc 60.40% <0.00%> (?)
addon-mobile 60.63% <0.00%> (?)
addon-table 60.75% <0.00%> (?)
addon-tablebars 96.15% <0.00%> (?)
cdk ∅ <0.00%> (?)
core 77.93% <0.00%> (?)
kit 70.28% <0.00%> (?)
summary 70.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's use Labeled with single l
  2. Let's use component tui-avatar-labeled instead of a directive
  3. Let's use gap instead of margin-bottom
  4. There shouldn't be a size input if all it affects is the width, the width should just rely on the size of the avatar inside of it
  5. I wonder if there's a way we can figure out automatically if the text going to take 1 or 2 lines?

@splincode splincode changed the title feat(experimental): add tuiAvatarLabelled feat(experimental): add tui-avatar-labeled Jan 24, 2024
@splincode
Copy link
Member Author

@waterplea updated

@splincode splincode merged commit a272bd4 into v3.x Jan 24, 2024
20 of 21 checks passed
@splincode splincode deleted the splincode/avatar-labelled branch January 24, 2024 13:11
This was referenced Jan 31, 2024
This was referenced Feb 20, 2024
This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants