-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): add tui-avatar-labeled
#6523
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 1ee41fd): https://taiga-ui--pr6523-splincode-avatar-lab-ngiggtzc.web.app (expires Thu, 25 Jan 2024 13:13:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles added (5)
Total files change +647.29KB Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.x #6523 +/- ##
=======================================
Coverage ? 70.56%
=======================================
Files ? 1097
Lines ? 13091
Branches ? 1849
=======================================
Hits ? 9238
Misses ? 3542
Partials ? 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6f0433a
to
ed24238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's use
Labeled
with singlel
- Let's use component
tui-avatar-labeled
instead of a directive - Let's use
gap
instead ofmargin-bottom
- There shouldn't be a
size
input if all it affects is the width, the width should just rely on the size of the avatar inside of it - I wonder if there's a way we can figure out automatically if the text going to take 1 or 2 lines?
tuiAvatarLabelled
tui-avatar-labeled
67f871c
to
260edd4
Compare
@waterplea updated |
projects/experimental/components/avatar-labelled/avatar-labeled.component.ts
Outdated
Show resolved
Hide resolved
projects/experimental/components/avatar-labelled/avatar-labeled.styles.less
Outdated
Show resolved
Hide resolved
260edd4
to
8457d8a
Compare
projects/experimental/components/avatar-labelled/avatar-labeled.component.ts
Outdated
Show resolved
Hide resolved
projects/experimental/components/avatar-labelled/avatar-labeled.styles.less
Outdated
Show resolved
Hide resolved
8457d8a
to
1ee41fd
Compare
PR Type
What kind of change does this PR introduce?
What is the new behaviour?