-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): prevent navigation to parent page if navigation occurs from dialog #6885
fix(kit): prevent navigation to parent page if navigation occurs from dialog #6885
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6885 +/- ##
==========================================
- Coverage 70.19% 64.04% -6.15%
==========================================
Files 1460 1095 -365
Lines 15934 11816 -4118
Branches 2292 1667 -625
==========================================
- Hits 11185 7568 -3617
+ Misses 4369 4005 -364
+ Partials 380 243 -137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +35B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
b8dd948
to
3598e12
Compare
projects/kit/components/routable-dialog/routable-dialog.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/routable-dialog/routable-dialog.component.ts
Outdated
Show resolved
Hide resolved
@Reactiver could you add cherry pick to v3.x please? |
3598e12
to
9906c0e
Compare
2a72bda
to
bce6d22
Compare
Closes #6636