Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): prevent navigation to parent page if navigation occurs from dialog #6885

Conversation

Reactiver
Copy link
Contributor

@Reactiver Reactiver commented Feb 26, 2024

Closes #6636

Copy link

lumberjack-bot bot commented Feb 26, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.04%. Comparing base (43c0ebb) to head (e1c394c).
Report is 213 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6885      +/-   ##
==========================================
- Coverage   70.19%   64.04%   -6.15%     
==========================================
  Files        1460     1095     -365     
  Lines       15934    11816    -4118     
  Branches     2292     1667     -625     
==========================================
- Hits        11185     7568    -3617     
+ Misses       4369     4005     -364     
+ Partials      380      243     -137     
Flag Coverage Δ
summary 64.04% <100.00%> (-6.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Feb 26, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
316.54KB (+35B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
206.37KB +10%
demo/browser/runtime.(hash).js
36.46KB +10%
demo/browser/styles.(hash).css
13.81KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change +35B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.2MB (+35B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Reactiver Reactiver changed the title fix(kit): prevent navigation to parent if navigation occurs from dialog fix(kit): prevent navigation to parent page if navigation occurs from dialog Feb 26, 2024
@Reactiver Reactiver force-pushed the fix/routable-dialog-navigated-from-dialog branch from b8dd948 to 3598e12 Compare February 26, 2024 18:55
@splincode
Copy link
Member

@Reactiver could you add cherry pick to v3.x please?

@splincode splincode force-pushed the fix/routable-dialog-navigated-from-dialog branch from 3598e12 to 9906c0e Compare March 2, 2024 08:31
@splincode splincode force-pushed the fix/routable-dialog-navigated-from-dialog branch from 2a72bda to bce6d22 Compare March 4, 2024 06:51
@splincode splincode merged commit 936a14b into taiga-family:main Mar 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Routable dialog bug when it's navigate to another route
3 participants