Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): fix horizontal scroll with tuiMultiSelectGroup and large item in tui-data-list #7374

Merged
merged 1 commit into from May 6, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented May 6, 2024

Done: remove overflow:hidden, which affects scrollWidth value
Closes #7306

Copy link

lumberjack-bot bot commented May 6, 2024

Failed tests ❌

After <= Diff => Before

input/input-table.cy.ts/components/__diff_output__/input_table__0_1.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__4_1.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__4_2.diff.png

(updated for commit 3b8938c)

Copy link

bundlemon bot commented May 6, 2024

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/main.(hash).js
390.68KB (+1.9KB +0.49%) +10%
demo/browser/vendor.(hash).js
214.57KB (+361B +0.16%) +10%
demo/browser/runtime.(hash).js
41.25KB (+163B +0.39%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
11.25KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

Total files change +2.41KB +0.37%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.4MB (+10.81KB +0.44%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented May 6, 2024

Visit the preview URL for this PR (updated for commit 3b8938c):

https://taiga-ui--pr7374-mdlufy-multi-select-4lo7408k.web.app

(expires Tue, 07 May 2024 14:34:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode merged commit 0e372c6 into v3.x May 6, 2024
33 of 34 checks passed
@splincode splincode deleted the mdlufy/multi-select-group branch May 6, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants