Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): close Hint and Dropdown when host is detached from dom #7593

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix(core): close Hint and Dropdown when host is detached from dom #7593

merged 2 commits into from
Jun 3, 2024

Conversation

vladimirpotekhin
Copy link
Member

Closes #7531

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented May 31, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2c3bc8c):

https://taiga-ui--pr7593-hint-host-3c3niebo.web.app

(expires Tue, 04 Jun 2024 09:20:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented May 31, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +391.97KB +10%
✅ demo/browser/vendor.(hash).js
 +214.57KB +10%
✅ demo/browser/runtime.(hash).js
 +41.32KB +10%
✅ demo/browser/polyfills.(hash).js
 +11.25KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +660.51KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.4MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@splincode splincode merged commit cf6d9f8 into v3.x Jun 3, 2024
30 checks passed
@splincode splincode deleted the hint-host branch June 3, 2024 09:42
@taiga-family-bot taiga-family-bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladimirpotekhin @waterplea @splincode