Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Hint fix content vertical centering with reduced line-height #7623

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

vladimirpotekhin
Copy link
Member

before with 16px line-height font:
Снимок экрана 2024-06-04 в 17 27 22

after:
Снимок экрана 2024-06-04 в 17 27 30

Closes #7259

Copy link

lumberjack-bot bot commented Jun 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Visit the preview URL for this PR (updated for commit 1ae9ce6):

https://taiga-ui--pr7623-hint-centering-9jvk8c3b.web.app

(expires Thu, 06 Jun 2024 09:45:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jun 4, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+392.14KB +10%
demo/browser/vendor.(hash).js
+214.57KB +10%
demo/browser/runtime.(hash).js
+41.32KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +660.67KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.4MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@vladimirpotekhin vladimirpotekhin linked an issue Jun 4, 2024 that may be closed by this pull request
9 tasks
@splincode splincode merged commit 57288f8 into v3.x Jun 6, 2024
30 of 31 checks passed
@splincode splincode deleted the hint-centering branch June 6, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - In mobile tui-hint has no center vertical align
3 participants