Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(addon-charts): use deep entry points for imports of other Taiga packages #7852

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

nsbarsukov
Copy link
Member

Partially solves #6723

@nsbarsukov nsbarsukov self-assigned this Jun 19, 2024
Copy link

lumberjack-bot bot commented Jun 19, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit c2869c8):

https://taiga-previews--pr7852-prefer-deep-imports-ghnva3u3.web.app

(expires Thu, 20 Jun 2024 15:02:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Jun 19, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
293.41KB (+137B +0.05%) +10%
demo/browser/runtime.(hash).js
40.55KB (+42B +0.1%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
243.83KB +10%
demo/browser/styles.(hash).css
13.95KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +179B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.53MB (-1.81KB -0.03%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov marked this pull request as ready for review June 19, 2024 15:23
@splincode splincode merged commit 009aaaf into main Jun 19, 2024
27 of 29 checks passed
@splincode splincode deleted the prefer-deep-imports-addon-charts branch June 19, 2024 15:29
@nsbarsukov nsbarsukov linked an issue Jun 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Use exact requests for internal imports
3 participants