Print the total number of feature flag combinations and progress #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
Build succeeded: |
taiki-e
added
the
C-enhancement
Merged
bors bot
added a commit
that referenced
this pull request
Oct 17, 2020
68: Always print progress r=taiki-e a=taiki-e Currently, progress is only printed when some options were specified (see #32), but I think it's better to always print it. Before: ```console $ cargo hack check --all info: running `cargo check` on member1 ... info: running `cargo check` on member2 ... info: running `cargo check` on member3 ... ``` After ```console $ cargo hack check --all info: running `cargo check` on member1 (1/3) ... info: running `cargo check` on member2 (2/3) ... info: running `cargo check` on member3 (3/3) ... ``` Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
removed
the
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
$ cargo hack --each-feature --workspace info: running `cargo check` on crate1 ... info: running `cargo check --no-default-features` on crate1 ... info: running `cargo check` on crate2 ...After:
$ cargo hack --each-feature --workspace info: running `cargo check` on crate1 (1/10) ... info: running `cargo check --no-default-features` on crate1 (2/10) ... info: running `cargo check` on crate2 (6/10) ...This is only enabled for
--each-featureand--feature-powersetthat may run the command multiple times with one crate.Closes #27