Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print progress #68

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Always print progress #68

merged 1 commit into from
Oct 17, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Oct 17, 2020

Currently, progress is only printed when some options were specified (see #32), but I think it's better to always print it.

Before:

$ cargo hack check --all
info: running `cargo check` on member1
...
info: running `cargo check` on member2
...
info: running `cargo check` on member3
...

After

$ cargo hack check --all
info: running `cargo check` on member1 (1/3)
...
info: running `cargo check` on member2 (2/3)
...
info: running `cargo check` on member3 (3/3)
...

@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Oct 17, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 17, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build succeeded:

@bors bors bot merged commit c1e3eba into master Oct 17, 2020
@bors bors bot deleted the progress branch October 17, 2020 03:16
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Jan 6, 2021
@taiki-e taiki-e added the A-diagnostics Area: Messages for errors and warnings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors and warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant