-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata for cargo bininstall #175
Conversation
In contrast with the default documented at <https://github.com/ryankurte/cargo-binstall#supporting-binary-installation>: - our pkg-url doesn't contain a version - bin-dir is just the executable without a parent directory - pkg-fmt is tar.gz, not tgz Fixes <taiki-e#168>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
Build succeeded: |
hmm $ cargo binstall cargo-llvm-cov
13:38:51 [INFO] Installing package: 'cargo-llvm-cov'
Error: unknown variant `tar.gz`, expected one of `tar`, `tgz`, `txz`, `zip`, `bin` for key `package.metadata.binstall.pkg-fmt` at line 121 column 1
Caused by:
unknown variant `tar.gz`, expected one of `tar`, `tgz`, `txz`, `zip`, `bin` for key `package.metadata.binstall.pkg-fmt` at line 121 column 1 UPDATE: filed #176 |
176: Fix metadata for cargo binstall r=taiki-e a=taiki-e #175 (comment) Co-authored-by: Taiki Endo <te316e89@gmail.com>
Confirmed $ cargo binstall cargo-llvm-cov
14:11:15 [INFO] Installing package: 'cargo-llvm-cov'
14:11:18 [INFO] Checking for package at: 'https://github.com/taiki-e/cargo-llvm-cov/releases/download/v0.4.3/cargo-llvm-cov-x86_64-apple-darwin.tar.gz'
14:11:19 [INFO] The package will be downloaded from github.com
14:11:19 [INFO] Downloading package from: 'https://github.com/taiki-e/cargo-llvm-cov/releases/download/v0.4.3/cargo-llvm-cov-x86_64-apple-darwin.tar.gz'
14:11:19 [INFO] This will install the following binaries:
14:11:19 [INFO] - cargo-llvm-cov (cargo-llvm-cov -> /Users/taiki/.cargo/bin/cargo-llvm-cov-v0.4.3)
14:11:19 [INFO] And create (or update) the following symlinks:
14:11:19 [INFO] - cargo-llvm-cov (/Users/taiki/.cargo/bin/cargo-llvm-cov -> cargo-llvm-cov-v0.4.3)
14:11:19 [INFO] Do you wish to continue? yes/no
yes
14:11:22 [INFO] Installing binaries...
14:11:22 [INFO] Installation complete! |
Thanks! :-) Sorry, the metadata looked almost trivial, I assumed that one can only test this for real with a released version (using the |
In contrast with the default documented at
https://github.com/ryankurte/cargo-binstall#supporting-binary-installation:
Fixes #168.