Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #252 #253

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Fix #252 #253

merged 5 commits into from
Apr 5, 2023

Conversation

andrewgazelka
Copy link
Contributor

@andrewgazelka andrewgazelka commented Apr 5, 2023 •
edited by taiki-e
Loading

did a little bit of testing. looks like this might fix it, but want your thoughts :)

Fixes #252

@andrewgazelka
Copy link
Contributor Author

andrewgazelka commented Apr 5, 2023 •
edited
Loading

looks reasonable for

taiki-e
taiki-e approved these changes Apr 5, 2023
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I confirmed my case is fixed by this)

@taiki-e taiki-e merged commit 80cd017 into taiki-e:main Apr 5, 2023
@taiki-e
Copy link
Owner

taiki-e commented Apr 5, 2023

Published in 0.5.14.

@andrewgazelka andrewgazelka deleted the codecov-fix branch April 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--codecov reports a line with no branches as only partially covered
2 participants
@andrewgazelka @taiki-e