Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support item attributes in any order #57

Merged
merged 2 commits into from Mar 4, 2021
Merged

Support item attributes in any order #57

merged 2 commits into from Mar 4, 2021

Conversation

SabrinaJewson
Copy link
Contributor

@SabrinaJewson SabrinaJewson commented Mar 3, 2021

Uses a tt-muncher so that the item's attributes are not restricted to be in a specific order. Multiple #[project]/#[project_ref]/#[project_replace] attributes will fail to compile unless there is a #[project]/#[project_ref]/#[project_replace] attribute in scope.

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 4, 2021

Build succeeded:

@bors bors bot merged commit fbedb0f into taiki-e:master Mar 4, 2021
@SabrinaJewson SabrinaJewson deleted the attr-unordered branch March 4, 2021 06:34
@taiki-e
Copy link
Owner

taiki-e commented Mar 4, 2021

Published in 0.2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants