Update to syn-2 #352
Update to syn-2 #352
Conversation
| @@ -1,4 +1,4 @@ | |||
| error: duplicate #[pin] attribute | |||
| error: expected attribute arguments in parentheses: `pin(...)` | |||
There was a problem hiding this comment.
Not a blocker, but this diagnostic regression is a bit odd.
There was a problem hiding this comment.
I adjusted the test to use an explicit #[pin] rather than your helper macro. Duplicate #[pin] still yields the correct error, it's a macro ordering issue that yields the must-have-argument issue.
Effectively bumps MSRV to 1.56.0, due to syn-2 minimum requirements.
| @@ -4,9 +4,9 @@ use auxiliary_macro::add_pin_attr; | |||
| use pin_project::pin_project; | |||
|
|
|||
| #[pin_project] | |||
| #[add_pin_attr(struct)] //~ ERROR duplicate #[pin] attribute | |||
There was a problem hiding this comment.
Sorry, could you revert this change?
This file is about interaction with the other macros that edit the struct, and normal "duplicate #[pin] attribute" cases have already been tested in invalid.rs.
pin-project/tests/ui/pin_project/invalid.rs
Lines 32 to 33 in a916a01
(Given that the previous error was not actually ideal either, it is probably not a problem that the message here changes. The ideal one is line 13's "#[pin] attribute may only be used on ...")
| # For test on MSRV. | ||
| once_cell = "=1.14" | ||
| serde = "=1.0.156" | ||
| serde = "=1.0.159" | ||
| toml = "=0.5.9" |
There was a problem hiding this comment.
I think these lines (and line 39's trybuild's = requirement) can be removed because MSRV has increased.
|
Merged as a part of #354. Thanks for your contribution! |
Effectively bumps MSRV to 1.56.0, due to syn-2 minimum requirements.