feat(docs-site): update multiple articles #17552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
approved these changes
Jun 11, 2024
adaki2004
reviewed
Jun 13, 2024
There was a problem hiding this comment.
To the excalidraw diagrams:
- maybe the first title is a bit misleading:
"Process message on source chain"- becaue we haveprocessMessage()call on the destination chain.. Maybe"Handle a message on source chain"or"Send message on source chain"could be better, since we anyways call those assendMessage()? - We no longer have EtherVault, could you remove from the excxalidraw ? And also maybe if something mentioning it in the text ? (Only EtherVault seems incorrect). Now we take custody of
Etherin theBridge.
Also now we dont have receiveToken() but instead onMessageInvocation(), can you exchange that in the text ?
Co-authored-by: D <51912515+adaki2004@users.noreply.github.com>
adaki2004
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.