Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protocol] add more tests #179

Merged
merged 36 commits into from Oct 22, 2022
Merged

[protocol] add more tests #179

merged 36 commits into from Oct 22, 2022

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Oct 17, 2022

Tests for:
EtherVault.sol
TokenVault.sol
BridgedERC20.sol

Bug fix for:
BridgedERC20.Sol - was checking srcToken in initializer and not _srcToken and thus was actually undeployable

…tarted. fixed bug in BridgedERC20 with incorrect srcToken being checked in init, making it impossible to initialize. added test coverage for this.
@vercel
Copy link

vercel bot commented Oct 17, 2022

@cyberhorsey is attempting to deploy a commit to the taikoxyz Team on Vercel.

To accomplish this, @cyberhorsey needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@vercel
Copy link

vercel bot commented Oct 18, 2022

@RogerLamTd is attempting to deploy a commit to the taikoxyz Team on Vercel.

To accomplish this, @RogerLamTd needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@vercel
Copy link

vercel bot commented Oct 20, 2022

An owner of the taikoxyz Team on Vercel accepted @cyberhorsey's request to join.

@cyberhorsey's commit is now being deployed.

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 11:55PM (UTC)

@cyberhorsey cyberhorsey marked this pull request as ready for review October 20, 2022 17:32
@dantaik dantaik changed the title Tests [protocol] add more tests Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants