Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protocol] fix LibMerkleTrie test cases failing occasionally #196

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

davidtaikocha
Copy link
Contributor

Some failed actions after #179 :

Looks like if Buffer.allocUnsafe creates a not-pre-filled buffer that unluckily contains an existed key in test trie, then this test case will fail:

This method differs from the `Buffer.alloc()` method because it creates a not-pre-filled buffer,
and it may contain information from older buffers. That is why it is called unsafe.

So this PR tries to fix this by creating a pre-filled buffer.

@vercel
Copy link

vercel bot commented Oct 27, 2022

@davidtaikocha is attempting to deploy a commit to the taikoxyz Team on Vercel.

To accomplish this, @davidtaikocha needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

dantaik
dantaik previously approved these changes Oct 27, 2022
@dantaik dantaik merged commit 3d94b5f into main Oct 27, 2022
@dantaik dantaik deleted the fix-workflow-errors-179 branch October 27, 2022 13:07
@vercel
Copy link

vercel bot commented Oct 27, 2022

An owner of the taikoxyz Team on Vercel accepted @davidtaikocha's request to join.

@davidtaikocha's commit is now being deployed.

@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
website ⬜️ Ignored (Inspect) Oct 27, 2022 at 2:27PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants