Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: transformer auto-resolve ambiguous types #2024

Merged
merged 19 commits into from
May 31, 2024

Conversation

ssddOnTop
Copy link
Member

@ssddOnTop ssddOnTop commented May 25, 2024

Issue Reference(s):
Fixes #1870
/claim 1870

TODO:

  • The Tailcall CLI no longer throws errors when the same type is used in both the input and output sections of the configuration.
  • Ambiguous type are automatically detected and resolved using the resolve_ambiguous_types function.
  • Integration test for this using execution_spec should be added.

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 25, 2024
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 86.07595% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 82.63%. Comparing base (f56f55d) to head (477a48f).

Files Patch % Lines
src/core/config/transformer/ambiguous_type.rs 90.95% 18 Missing ⚠️
src/core/config/transformer/mod.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   82.70%   82.63%   -0.08%     
==========================================
  Files         178      180       +2     
  Lines       18039    18080      +41     
==========================================
+ Hits        14920    14941      +21     
- Misses       3119     3139      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 27, 2024
@tusharmath tusharmath changed the title chore: auto-resolve ambiguous types feat: auto-resolve ambiguous types May 30, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 30, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 30, 2024
tests/core/spec.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath added ci: lint Automatically fix the linters issues and make a commit and removed type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels May 31, 2024
@tusharmath tusharmath changed the title feat: auto-resolve ambiguous types chore: transformer auto-resolve ambiguous types May 31, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 31, 2024 08:44
@tusharmath tusharmath merged commit 0fa7e10 into main May 31, 2024
28 checks passed
@tusharmath tusharmath deleted the chore/resolve-ambiguous-types-cli1 branch May 31, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim ci: lint Automatically fix the linters issues and make a commit type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Ambiguous Types in Configuration Automatically
2 participants