[stack]: redesign errors - 0 #2147
Open
+2,078
−1,138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(deps): update dependency tsx to v4.13.3 * chore(deps): update rust crate async-graphql to v7.0.6 * refactor: rename EvaluationError to Error --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-actions
bot
added
the
type: chore
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
- Coverage 85.92% 85.84% -0.08%
==========================================
Files 227 235 +8
Lines 21792 21777 -15
==========================================
- Hits 18724 18694 -30
- Misses 3068 3083 +15 ☔ View full report in Codecov by Sentry. |
Co-authored-by: mehulmathur001 <160306774+mehulmathur001@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
# Conflicts: # Cargo.toml
# Conflicts: # src/core/http/request_context.rs # src/core/ir/io.rs
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
mehulmathur16
removed
the
state: inactive
# Conflicts: # src/core/app_context.rs # src/core/ir/cache.rs # src/core/ir/eval.rs # src/core/ir/io.rs # src/core/ir/mod.rs
# Conflicts: # src/core/app_context.rs # src/core/config/transformer/type_merger/type_merger.rs # src/core/config/transformer/type_name_generator.rs # src/core/generator/from_json.rs # src/core/generator/from_proto.rs # src/core/generator/json/field_base_url_generator.rs # src/core/generator/json/schema_generator.rs # src/core/http/request_context.rs # src/core/ir/cache.rs # src/core/ir/eval.rs # src/core/ir/eval_http.rs # src/core/ir/mod.rs # tests/expression_spec.rs
|
| Report | Wed, June 26, 2024 at 20:00:16 UTC |
| Project | tailcall |
| Branch | 2147/merge |
| Testbed | benchmarking-runner |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| from_json_bench | ✅ (view plot) | 7,198,300.00 (+0.94%) | 7,260,258.57 (99.15%) |
| group_by | ✅ (view plot) | 544.35 (-3.87%) | 631.63 (86.18%) |
| input/args.missing | ✅ (view plot) | 25.92 (+7.46%) | 27.40 (94.61%) |
| input/args.nested.existing | ✅ (view plot) | 53.54 (+12.23%) | 61.95 (86.41%) |
| input/args.nested.missing | ✅ (view plot) | 36.36 (-4.48%) | 40.90 (88.90%) |
| input/args.root | ✅ (view plot) | 48.84 (+10.78%) | 59.01 (82.77%) |
| input/headers.existing | ✅ (view plot) | 32.85 (+3.83%) | 33.86 (97.02%) |
| input/headers.missing | ✅ (view plot) | 31.55 (+2.70%) | 33.68 (93.67%) |
| input/value.missing | ✅ (view plot) | 23.41 (-0.12%) | 24.99 (93.68%) |
| input/value.nested.existing | ✅ (view plot) | 40.12 (-3.51%) | 45.09 (88.98%) |
| input/value.nested.missing | ✅ (view plot) | 36.98 (+0.85%) | 38.67 (95.63%) |
| input/value.root | ✅ (view plot) | 35.59 (-6.44%) | 41.59 (85.59%) |
| input/vars.existing | ✅ (view plot) | 7.45 (-4.32%) | 9.09 (81.95%) |
| input/vars.missing | ✅ (view plot) | 10.96 (+9.67%) | 13.42 (81.68%) |
| synth_nested | ✅ (view plot) | 20,740.00 (-0.88%) | 21,504.97 (96.44%) |
| test_batched_body | ✅ (view plot) | 2,675.70 (-99.00%) | 1,553,931.34 (0.17%) |
| test_batched_body #2 | ✅ (view plot) | 1,624,600.00 (-4.45%) | 1,822,807.85 (89.13%) |
| test_data_loader | ✅ (view plot) | 470,690.00 (+0.36%) | 485,386.71 (96.97%) |
| test_handle_request | ✅ (view plot) | 152,620.00 (-2.28%) | 171,619.09 (88.93%) |
| test_http_execute_method | ✅ (view plot) | 17,898.00 (-1.44%) | 19,260.68 (92.93%) |
| with_mustache_expressions | ✅ (view plot) | 1,185.10 (+1.61%) | 1,231.45 (96.24%) |
| with_mustache_literal | ✅ (view plot) | 769.47 (+6.64%) | 777.71 (98.94%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
Co-authored-by: mehulmathur001 <160306774+mehulmathur001@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #1508
colorfromcore::Erratathiserror::ErrorfromErrata. It is not an error so remove it from places where it's being used like one.thiserror::Errorfrom everywhere.