Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query batching #2166

Merged
merged 66 commits into from
Jun 12, 2024
Merged

feat: query batching #2166

merged 66 commits into from
Jun 12, 2024

Conversation

amitksingh1490
Copy link
Collaborator

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Jun 11, 2024
@amitksingh1490 amitksingh1490 changed the title Feat/query batching feat: query batching Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 78.08219% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (82aed52) to head (c52a3ea).

Files Patch % Lines
src/core/async_graphql_hyper.rs 60.52% 15 Missing ⚠️
src/core/app_context.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2166      +/-   ##
==========================================
- Coverage   84.15%   84.12%   -0.04%     
==========================================
  Files         212      212              
  Lines       19982    20054      +72     
==========================================
+ Hits        16816    16870      +54     
- Misses       3166     3184      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitksingh1490 amitksingh1490 marked this pull request as ready for review June 11, 2024 12:20
src/core/http/mod.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 11, 2024

🐰Bencher

ReportWed, June 12, 2024 at 07:55:26 UTC
Projecttailcall
Branch2166/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,238,700.00 (+1.58%)7,271,842.45 (99.54%)
group_by✅ (view plot)532.84 (-7.66%)646.76 (82.39%)
input/args.missing✅ (view plot)23.03 (-4.46%)26.90 (85.59%)
input/args.nested.existing✅ (view plot)42.48 (-11.75%)63.06 (67.36%)
input/args.nested.missing✅ (view plot)38.27 (+0.36%)40.49 (94.52%)
input/args.root✅ (view plot)38.18 (-14.06%)59.81 (63.84%)
input/headers.existing✅ (view plot)32.90 (+3.86%)33.70 (97.61%)
input/headers.missing✅ (view plot)31.57 (+2.70%)33.52 (94.17%)
input/value.missing✅ (view plot)23.31 (-0.57%)24.92 (93.57%)
input/value.nested.existing✅ (view plot)40.97 (-1.46%)44.89 (91.26%)
input/value.nested.missing✅ (view plot)37.09 (+1.40%)38.58 (96.14%)
input/value.root✅ (view plot)37.18 (-2.60%)41.52 (89.53%)
input/vars.existing✅ (view plot)8.14 (+2.98%)8.93 (91.13%)
input/vars.missing✅ (view plot)11.79 (+24.50%)12.76 (92.40%)
test_batched_body✅ (view plot)2,690.10 (-99.49%)2,171,510.02 (0.12%)
test_batched_body #2✅ (view plot)1,704,900.00 (-0.23%)1,837,490.94 (92.78%)
test_data_loader✅ (view plot)476,100.00 (+1.39%)486,955.74 (97.77%)
test_handle_request✅ (view plot)149,580.00 (-4.95%)174,937.56 (85.50%)
test_http_execute_method✅ (view plot)18,098.00 (-1.26%)19,440.54 (93.09%)
with_mustache_expressions✅ (view plot)1,143.00 (-2.05%)1,230.46 (92.89%)
with_mustache_literal✅ (view plot)670.21 (-7.14%)775.32 (86.44%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@tusharmath tusharmath enabled auto-merge (squash) June 12, 2024 07:34
@amitksingh1490 amitksingh1490 removed the ci: benchmark Runs benchmarks label Jun 12, 2024
@tusharmath tusharmath merged commit 2234777 into main Jun 12, 2024
30 of 32 checks passed
@tusharmath tusharmath deleted the feat/query-batching branch June 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants