fix: improved type similarity detection logic. #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes to be merged.
- added unit tests.
github-actions
bot
added
the
type: fix
laststylebender14
changed the base branch from
main
to
bug/handle-merging-of-input-types
laststylebender14
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bug/handle-merging-of-input-types #2231 +/- ##
=====================================================================
+ Coverage 86.04% 86.16% +0.12%
=====================================================================
Files 212 212
Lines 20174 20357 +183
=====================================================================
+ Hits 17358 17541 +183
Misses 2816 2816 ☔ View full report in Codecov by Sentry. |
laststylebender14
changed the title
laststylebender14
changed the title
amitksingh1490
force-pushed
the
bug/handle-merging-of-input-types
branch
from
44a8b3e
to
d691ada
Compare
amitksingh1490
approved these changes
Jun 21, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…are (#2222) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ired-fields-correctly-for-type-merging
laststylebender14
merged commit 5190e97
into
bug/handle-merging-of-input-types
5 checks passed
laststylebender14
deleted the
bug/handle-required-fields-correctly-for-type-merging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>