Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dropped pub fields from config module #2260

Conversation

dekkku
Copy link
Contributor

@dekkku dekkku commented Jun 23, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2256
/claim #2256

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jun 23, 2024
Copy link

algora-pbc bot commented Jun 23, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

@dekkku dekkku changed the title refactore: dropped pub fields from config module chore: dropped pub fields from config module Jun 23, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 23, 2024
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 91.75258% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.80%. Comparing base (417c4e6) to head (e163d36).

Files Patch % Lines
src/cli/tc.rs 0.00% 6 Missing ⚠️
tailcall-aws-lambda/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   85.82%   85.80%   -0.03%     
==========================================
  Files         225      225              
  Lines       21393    21392       -1     
==========================================
- Hits        18361    18355       -6     
- Misses       3032     3037       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 23, 2024

🐰Bencher

ReportThu, June 27, 2024 at 11:51:26 UTC
Projecttailcall
Branch2260/merge
Testbedbenchmarking-runner

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
input/value.missingLatency (nanoseconds (ns))🚨 (view plot | view alert)29.34 (+25.06%)25.19 (116.47%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,133,600.00 (+0.04%)7,258,146.15 (98.28%)
group_by✅ (view plot)547.61 (-3.25%)630.96 (86.79%)
input/args.missing✅ (view plot)25.49 (+5.70%)27.39 (93.08%)
input/args.nested.existing✅ (view plot)53.77 (+12.74%)61.92 (86.84%)
input/args.nested.missing✅ (view plot)38.52 (+1.18%)40.90 (94.18%)
input/args.root✅ (view plot)52.04 (+18.02%)59.03 (88.17%)
input/headers.existing✅ (view plot)30.38 (-3.95%)33.85 (89.73%)
input/headers.missing✅ (view plot)29.22 (-4.84%)33.67 (86.76%)
input/value.missing🚨 (view plot | view alert)29.34 (+25.06%)25.19 (116.47%)
input/value.nested.existing✅ (view plot)40.74 (-2.03%)45.09 (90.35%)
input/value.nested.missing✅ (view plot)36.78 (+0.29%)38.67 (95.12%)
input/value.root✅ (view plot)37.19 (-2.25%)41.58 (89.45%)
input/vars.existing✅ (view plot)8.21 (+5.54%)9.08 (90.39%)
input/vars.missing✅ (view plot)12.06 (+20.46%)13.43 (89.76%)
synth_nested✅ (view plot)20,764.00 (-0.74%)21,484.39 (96.65%)
test_batched_body✅ (view plot)2,679.80 (-98.97%)1,533,835.11 (0.17%)
test_batched_body #2✅ (view plot)1,606,600.00 (-5.51%)1,822,923.55 (88.13%)
test_data_loader✅ (view plot)473,010.00 (+0.85%)485,404.79 (97.45%)
test_handle_request✅ (view plot)156,980.00 (+0.51%)171,582.53 (91.49%)
test_http_execute_method✅ (view plot)17,792.00 (-2.01%)19,256.14 (92.40%)
with_mustache_expressions✅ (view plot)1,191.80 (+2.18%)1,231.69 (96.76%)
with_mustache_literal✅ (view plot)765.25 (+6.06%)777.59 (98.41%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Jun 23, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 23, 2024
@dekkku dekkku requested a review from tusharmath June 25, 2024 21:03
@tusharmath tusharmath enabled auto-merge (squash) June 27, 2024 11:33
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Jun 27, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 27, 2024
@tusharmath tusharmath merged commit 9411c2c into tailcallhq:main Jun 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Drop pub from all the fields of ConfigModule
2 participants