-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dropped pub fields from config module #2263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci: benchmark
Runs benchmarks
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
labels
Jun 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
+ Coverage 85.69% 85.72% +0.03%
==========================================
Files 219 219
Lines 21043 21061 +18
==========================================
+ Hits 18033 18055 +22
+ Misses 3010 3006 -4 ☔ View full report in Codecov by Sentry. |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
tusharmath
reviewed
Jun 23, 2024
tusharmath
reviewed
Jun 23, 2024
tusharmath
added a commit
that referenced
this pull request
Jun 23, 2024
This reverts commit cc0c27a.
Merged it by mistake |
re-opened here #2274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: benchmark
Runs benchmarks
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue Reference(s):
Fixes #2256
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>