change dot const to u8 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's strange. What version of rustc do you have? |
|
rustc 1.18.0 |
|
Oh.. I'm sorry. Didn't realize c_char was defined differently between aarch64 and x86_64. That was why it didn't compile on my odroid C2. |
|
Wow! So after this PR does it compile on both architectures? |
Merged
|
No, it just won't compile in x86_64 instead. But with #4 it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tailhook,
Couldn't help but notice that
openatdoesn't compile.After this change it does.
Ran the tests, nothing seems negatively affected by this.