Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serve/simple: Use message passing instead of HTTP #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

serve/simple: Use message passing instead of HTTP #56

wants to merge 1 commit into from

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Jun 12, 2023 •
edited
Loading

Implements a framework to support asynchronous requests using messages.

Part of #36

TODO:

  • Resolve why isMutating is not being set.

@tylersmalley tylersmalley changed the title serve/simple: Use message passing instead of HTTP WIP: serve/simple: Use message passing instead of HTTP Jun 12, 2023
@tylersmalley tylersmalley changed the title WIP: serve/simple: Use message passing instead of HTTP serve/simple: Use message passing instead of HTTP Jun 12, 2023
@tylersmalley tylersmalley marked this pull request as draft June 12, 2023 15:58
@tylersmalley tylersmalley force-pushed the tyler/messages branch 3 times, most recently from d2c8fdf to 2f3846d Compare June 14, 2023 20:59
@tylersmalley tylersmalley marked this pull request as ready for review June 14, 2023 21:00
@tylersmalley tylersmalley force-pushed the tyler/messages branch 4 times, most recently from 17bfc94 to 47b3d50 Compare July 1, 2023 01:43
@tylersmalley tylersmalley force-pushed the tyler/messages branch 3 times, most recently from 7bc06e7 to 15a5808 Compare July 10, 2023 21:45
@tylersmalley
serve/simple: Use message passing instead of HTTP
17ee931 
Implements a frameworks to support asynchronous requests using messages.

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley added a commit that referenced this pull request Jul 20, 2023
@tylersmalley
test: Removes @vscode/test-electron
01a3f65 
We were not using this test infrastructure, and after #56 it should be better to accomplish these tests using something like playwright.

@vscode/test-electron is really not ideal. It's heavy, and does not provide any tooling to test webviews, which we make use of.

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
@tylersmalley tylersmalley mentioned this pull request Jul 20, 2023
Merged
tylersmalley added a commit that referenced this pull request Jul 20, 2023
@tylersmalley
test: Removes @vscode/test-electron (#114)
c725c5b 
We were not using this test infrastructure, and after #56 it should be
better to accomplish these tests using something like playwright.

@vscode/test-electron is really not ideal. It's heavy, and does not
provide any tooling to test webviews, which we make use of.

---------

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley added a commit that referenced this pull request Jul 20, 2023
@tylersmalley
test: Removes @vscode/test-electron
9f2a078 
We were not using this test infrastructure, and after #56 it should be better to accomplish these tests using something like playwright.

@vscode/test-electron is really not ideal. It's heavy, and does not provide any tooling to test webviews, which we make use of.

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tylersmalley