[tailscale1.17] crypto/x509: do not gzip certs #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the binary size associated with strings and other data that is never touched does not meaningfully impact iOS memory usage. Use the strings directly instead of gzipping them. Use unsafe shenanigans to avoid copying them. This saves about 100k of memory on startup. Change-Id: I1a5ea92fe99289028d1b6fbbdea1a491c1c26066
|
Makes sense (given what we now know), but what does this do to our binary size regardless? |
|
Adds 17040 bytes. |
|
ship it :) |
bradfitz
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the binary size associated with strings
and other data that is never touched does not meaningfully
impact iOS memory usage.
Use the strings directly instead of gzipping them.
Use unsafe shenanigans to avoid copying them.
This saves about 100k of memory on startup.