Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Ability to bypass owner checks #18

Closed
nikola-n6c opened this issue Dec 2, 2022 · 2 comments
Closed

FR: Ability to bypass owner checks #18

nikola-n6c opened this issue Dec 2, 2022 · 2 comments

Comments

@nikola-n6c
Copy link

Hi folks,

Thanks for putting this together, it's incredible!

We're using this in a smaller company, and would like the ability to opt-out of ownership checks when editing links. At our scale (<10 engs) it's somewhat more useful to let anyone change these.

Ideally this would be a checkbox during the golink creation, thinking we can iterate towards there. Useful crawl solution can be a global flag to opt-out of the checks (a la -skip-ownership-checks).

Happy to take this on if you think it's directionally right.

@willnorris
Copy link
Member

This is something that did come up in the early days of golink and we discussed it briefly. I've worked at companies that had both models, and don't necessarily have strong feelings about it, but we did settle on enforcing ownership. A few things that I think are really helpful if you don't enforce ownership are email notifications when someone edits your link and/or an edit history so you can see what was changed. We don't have either one of those right now.

My last company was the no-enforced-ownership model, so I initially advocated for that. However in practice, we haven't found the ownership to be much of an issue. Occasionally, I'll message someone asking that they update a golink or change ownership, and it's pretty straightforward. Would you be willing to try it for a little while and see how much of a problem is ends up being?

willnorris added a commit that referenced this issue Apr 2, 2024
Updates #18
Updates #22
Updates #86
Updates #120

Signed-off-by: Will Norris <will@tailscale.com>
willnorris added a commit that referenced this issue Apr 2, 2024
Updates #18
Updates #22
Updates #86
Updates #120

Signed-off-by: Will Norris <will@tailscale.com>
willnorris added a commit that referenced this issue Apr 2, 2024
Updates #18
Updates #22
Updates #86
Updates #120

Signed-off-by: Will Norris <will@tailscale.com>
@willnorris
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants