setectest: add a package to simplify testing #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package contains a plug-compatible wrapper around server.Server and db.DB for use with the httptest package to serve secrets in unit tests. Pulls the unexported testDB wrapper out of the db_test package into an exported type, and updates the existing tests to use the new thing. Add a Server wrapper to do the same for the HTTP plumbing, and include some affordances for setup. Signed-off-by: M. J. Fromberger <fromberger@tailscale.com>
creachadair
force-pushed
the
mjf/setectest
branch
from
9d51c3b
to
fa76a78
Compare
creachadair
changed the title
creachadair
added a commit
to tailscale/tailsql
that referenced
this pull request
Aug 14, 2023
Extend the DBSpec type to allow specifying a secret name for the connection string instead of a URL or file. Move URL resolution from the validation step to the open step, so that validation is cheap and idempotent. Add an Option to hold a setec.Store, and export the CheckSources method so the caller can find out which secrets they need to include. Enforce that a secret store is present during construction of the service, if any of the sources requires it. Add a test to exercise using the new secret field (requires tailscale/setec#36). Signed-off-by: M. J. Fromberger <fromberger@tailscale.com>
danderson
approved these changes
Aug 14, 2023
danderson
approved these changes
Aug 14, 2023
creachadair
added a commit
to tailscale/tailsql
that referenced
this pull request
Aug 14, 2023
Extend the DBSpec type to allow specifying a secret name for the connection string instead of a URL or file. Move URL resolution from the validation step to the open step, so that validation is cheap and idempotent. Add an Option to hold a setec.Store, and export the CheckSources method so the caller can find out which secrets they need to include. Enforce that a secret store is present during construction of the service, if any of the sources requires it. Add a test to exercise using the new secret field (requires tailscale/setec#36). Signed-off-by: M. J. Fromberger <fromberger@tailscale.com>
creachadair
added a commit
to tailscale/tailsql
that referenced
this pull request
Aug 14, 2023
Extend the DBSpec type to allow specifying a secret name for the connection string instead of a URL or file. Move URL resolution from the validation step to the open step, so that validation is cheap and idempotent. Add an Option to hold a setec.Store, and export the CheckSources method so the caller can find out which secrets they need to include. Enforce that a secret store is present during construction of the service, if any of the sources requires it. Add a test to exercise using the new secret field (requires tailscale/setec#36). Signed-off-by: M. J. Fromberger <fromberger@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package contains a plug-compatible wrapper around server.Server and db.DB
for use with the httptest package to serve secrets in unit tests.
Pulls the unexported testDB wrapper out of the db_test package into an exported
type, and updates the existing tests to use the new thing. Add a Server wrapper
to do the same for the HTTP plumbing, and include some affordances for setup.