use network callback to update DNS config when network changes #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config -Call netmon.InjectEvent on network change to indicate a change Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added Fixes #10107
danderson
reviewed
Jan 12, 2024
|
Oh, and you need to make the commit say |
-Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config -Call netmon.InjectEvent on network change to indicate a change Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added Updates tailscale/tailscale/#10107 hi
-Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config -Call netmon.InjectEvent on network change to indicate a change Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added Updates tailscale/tailscale/#10107
danderson
approved these changes
Jan 17, 2024
| } | ||
|
|
||
| s = getDnsServersFromSystemProperties(); | ||
| String s = getDnsConfigs(); | ||
| if (!s.trim().isEmpty()) { |
There was a problem hiding this comment.
unnecessary? We're now returning empty string regardless
There was a problem hiding this comment.
We return the string if it's nonempty
There was a problem hiding this comment.
Sure, but if the string is empty, we return "" below. So, you could skip the conditional and always return getDnsConfigs().trim() for the same effect
tm-sanjay
pushed a commit
to SwiftSku/tailscale-android-pos
that referenced
this pull request
Jan 24, 2024
…cale#147) * use network callback to update DNS config when network changes -Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config -Call netmon.InjectEvent on network change to indicate a change Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added Fixes #10107 * use network callback to update DNS config when network changes -Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config -Call netmon.InjectEvent on network change to indicate a change Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added Updates tailscale/tailscale/#10107 hi * hi * . * use network callback to update DNS config when network changes -Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config -Call netmon.InjectEvent on network change to indicate a change Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added Updates tailscale/tailscale/#10107 * fixed missing connectivity manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Use requestNetwork, which gets the best network matching the passed in network request, to listen for changes to network and cache DNS config
-Call netmon.InjectEvent on network change to indicate a change
Follow-up will fix issue in netmon where IsMajorChangeFrom doesn't identify major changes when a network is added
Updates tailscale/tailscale#10107