-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/exit node status indicators (emphasizes the added functionality) #177
UI/exit node status indicators (emphasizes the added functionality) #177
Conversation
Signed-off-by: Aalok Kamble <aalok.kamble@gmail.com>
Aligned dot vertically with lowercase letters for machine names. Reverted 'Machine' to 'My devices' Signed-off-by: Aalok Kamble <aalok.kamble@gmail.com>
Improved clarity: Unavailable nodes are now displayed in gray for better indication of their status. Enhanced user experience: The selected exit node, if online, is now highlighted in red on the main screen for clear visual confirmation. This commit message effectively conveys the following: Action: Refactored the code for the UI. Specific changes: Introduced visual cues for unavailable nodes. Implemented highlighting for the selected exit node, indicating its online status. Benefit: Improved clarity and user experience.
…phasizes-the-added-functionality)
@sonovawolf Please review. I know this is not the place to discuss changes but here is my recommendation: current single file, ui.go, is getting cumbersome. Splitting it offers advantages: Readability: Functions grouped by purpose make code easier to understand. Here's the plan: Analyze: Identify logical boundaries in ui.go to split by features. Splitting ui.go will create a cleaner, more manageable codebase for future development. |
Hey @aalokkamble, thank you so much for preparing these contributions! We've just started on a large set of changes that will replace the gioui code in this application with a Kotlin implemented GUI instead, which we expect will improve our maintenance costs and improve our ability to ensure that our app keeps up with the latest Android features. We do not yet have an organized way for contributors to follow that work stream, as it's still relatively early, getting the initial IPC and build system wiring in a good state. The existing gioui code base will be entering a bug-fix only phase as we move forward with this new strategy. |
Closing this PR since it targets the old Go codebase, and the feature has been implemented in recently shipped versions. |
Refactored code exit node screen UI and improved visual feedback: