android: use EditPrefs instead of passing UpdatePrefs to start #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
approved these changes
May 7, 2024
|
"Updats", whoops! 😝 |
bradfitz
reviewed
May 7, 2024
| fun login(options: Ipn.Options = Ipn.Options(), completionHandler: (Result<Unit>) -> Unit = {}) { | ||
|
|
||
| fun login( | ||
| options: Ipn.Options = Ipn.Options(), |
There was a problem hiding this comment.
maybe you should just take the authKey string only? You don't have separate frontend-vs-backend log IDs on Android now, do you?
bradfitz
reviewed
May 7, 2024
| start.onFailure { completionHandler(Result.failure(it)) }.onSuccess { loginAction() } | ||
| val startAction = { | ||
| Client(viewModelScope).start(options) { start -> | ||
| start.onFailure { completionHandler(Result.failure(it)) }.onSuccess { loginAction() } |
There was a problem hiding this comment.
if this is the style, that's fine, but I personally think it's sad that onFailure and onSuccess's bodies don't line up in any way.
There was a problem hiding this comment.
Yeah, that's the auto-formatter.
bradfitz
approved these changes
May 7, 2024
This allows us to precisely set the options we need during login and avoid wiping away defaults like AllowSingleHosts. Updates tailscale/tailscale#11731 Signed-off-by: Percy Wegmann <percy@tailscale.com>
|
Thanks for the review @agottardo, @bradfitz and @MulverineX |
kari-ts
added a commit
to tailscale/tailscale
that referenced
this pull request
May 7, 2024
Web version of tailscale/tailscale-android#370 This allows us to update the prefs rather than creating new prefs Updates #11731 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
to tailscale/tailscale
that referenced
this pull request
May 7, 2024
Web version of tailscale/tailscale-android#370 This allows us to update the prefs rather than creating new prefs Updates #11731 Signed-off-by: kari-ts <kari@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to precisely set the options we need during login and avoid wiping away defaults like AllowSingleHost.
Updats tailscale/tailscale#11731