android: fix connect VPN permissions #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
approved these changes
May 16, 2024
| @@ -82,20 +105,47 @@ class MainViewModel : IpnViewModel() { | |||
| } | |||
| } | |||
|
|
|||
| fun maybeShowVpnPermissionLauncher() { | |||
There was a problem hiding this comment.
Perhaps rename to "showVPNPermissionLauncherIfUnauthorized"? Or whatever makes it clearer what it does. :)
-show VPN connection permissions after intro screen -make toggle state and main view take VPN preparedness into consideration Fixes tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 28, 2024
#398 introduced a bug where we were not calling startVPN after getting (or confirming) VPN.prepare permissions This resulted in the VPN not being turned on after logging in for the first time Updates tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
May 29, 2024
-show VPN connection permissions after intro screen -make toggle state and main view take VPN preparedness into consideration Fixes tailscale/tailscale#12148 Signed-off-by: kari-ts <kari@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screen-20240516-134659.mp4
-show VPN connection permissions after intro screen -make toggle state and main view take VPN preparedness into consideration
Fixes tailscale/tailscale#12148