android: exit node banner ui improvements #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
reviewed
May 21, 2024
agottardo
reviewed
May 21, 2024
| @@ -287,6 +334,44 @@ val ColorScheme.secondaryButton: ButtonColors | |||
| } | |||
| } | |||
|
|
|||
| val ColorScheme.offButton: ButtonColors | |||
There was a problem hiding this comment.
Same: exitNodeOfflineButton
agottardo
reviewed
May 21, 2024
android/src/main/java/com/tailscale/ipn/ui/viewModel/IpnViewModel.kt
Outdated
Show resolved
Hide resolved
kari-ts
force-pushed
the
kari/exitstatus
branch
3 times, most recently
from
08b46d9
to
4e1e3ce
Compare
-show if device is running as an exit node -show exit node connection status Updates tailscale/corp#19122 Follow up will include: -make exit node picker recompose when exit node connection status changes -prevent user from running as exit node if it is using an exit node and vice versa instead of silently failing -add explanation box for MDM offline state Signed-off-by: kari-ts <kari@tailscale.com>
sonovawolf
approved these changes
May 22, 2024
kari-ts
added a commit
that referenced
this pull request
May 29, 2024
-show if device is running as an exit node -show exit node connection status Updates tailscale/corp#19122 Follow up will include: -make exit node picker recompose when exit node connection status changes -prevent user from running as exit node if it is using an exit node and vice versa instead of silently failing -add explanation box for MDM offline state Signed-off-by: kari-ts <kari@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-show if device is running as an exit node
-if device is running as exit node, show button to stop running as exit node
-show exit node connection status
-for exit nodes, tapping 'disable' should result in the exit node being set to none but the banner still showing this exit node, with an 'enable' button which sets the exit node to this one
Updates https://github.com/tailscale/corp/issues/19122
Follow up will include:
-prevent user from running as exit node if it is using an exit node and vice versa instead of silently failing
-further handle MDM state - no buttons for MDM
-add explanation box for MDM offline state