android/ui: fix AndroidTV navigation issues #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates tailscale/corp#20930 This addresses several issues with AndroidTV navigation: The search bar is removed until we have a better solution for D-pad navigation. This should be addressed when we switch to a less customized component. Full replacement of the search functionality is beyond the scope of this change. The back button will now automatically request the focus on AndroidTV devices by default so there is always at least one element focussed. Views with clipboard support are disabled since this was not functional (nothing was getting copied to the clipboard). View with embedded links are removed since these require touch support and a browser. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
agottardo
approved these changes
Jun 17, 2024
barnstar
added a commit
that referenced
this pull request
Jun 20, 2024
updates tailscale/corp#20930 This addresses several issues with AndroidTV navigation: The search bar is removed until we have a better solution for D-pad navigation. This should be addressed when we switch to a less-customized component. Full replacement of the search functionality is beyond the scope of this change. The back button will now automatically request the focus on AndroidTV devices by default so there is always at least one element focussed. Views with clipboard support are disabled since this was not functional (nothing was getting copied to the clipboard). View with embedded links are removed since these require touch support and a browser. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tailscale/corp#20930
This addresses several issues with AndroidTV navigation,
all possible causes of the 1.68 rejection (the exact reasons
are unknown - we're await clarification). But in the mean time:
The search bar is removed until we have a better solution
for D-pad navigation. This should be addressed when we
switch to a less customized component. Full replacement of
the search functionality is beyond the scope of this change.
The back button will now automatically request the focus on AndroidTV
devices by default so there is always at least one element focussed.
Views with clipboard support are disabled since this was
not functional (nothing was getting copied to the clipboard).
View with embedded links are removed since these
require touch support and a browser.