Skip to content

Commit

Permalink
wgengine/netstack: disable RACK on Windows (#10402)
Browse files Browse the repository at this point in the history
Updates #9707

Signed-off-by: Jordan Whited <jordan@tailscale.com>
  • Loading branch information
jwhited committed Nov 28, 2023
1 parent 5f40b8a commit 5e861c3
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions wgengine/netstack/netstack.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,17 @@ func Create(logf logger.Logf, tundev *tstun.Wrapper, e wgengine.Engine, mc *magi
if tcpipErr != nil {
return nil, fmt.Errorf("could not enable TCP SACK: %v", tcpipErr)
}
if runtime.GOOS == "windows" {
// See https://github.com/tailscale/tailscale/issues/9707
// Windows w/RACK performs poorly. ACKs do not appear to be handled in a
// timely manner, leading to spurious retransmissions and a reduced
// congestion window.
tcpRecoveryOpt := tcpip.TCPRecovery(0)
tcpipErr = ipstack.SetTransportProtocolOption(tcp.ProtocolNumber, &tcpRecoveryOpt)
if tcpipErr != nil {
return nil, fmt.Errorf("could not disable TCP RACK: %v", tcpipErr)
}
}
linkEP := channel.New(512, uint32(tstun.DefaultTUNMTU()), "")
if tcpipProblem := ipstack.CreateNIC(nicID, linkEP); tcpipProblem != nil {
return nil, fmt.Errorf("could not create netstack NIC: %v", tcpipProblem)
Expand Down

0 comments on commit 5e861c3

Please sign in to comment.