Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgengine/magicsock: TestTwoDevicePing test flake #11762

Open
bradfitz opened this issue Apr 16, 2024 · 0 comments
Open

wgengine/magicsock: TestTwoDevicePing test flake #11762

bradfitz opened this issue Apr 16, 2024 · 0 comments
Labels
testing

Comments

@bradfitz
Copy link
Member

At ca5cb41 ...

cloud@cloud:~/tailscale$ time ./tool/go test -v  -count=100 -failfast -run=TwoDevice ./wgengine/magicsock/
...
=== RUN   TestTwoDevicePing/ping_1.0.0.2_via_SendPacket
    magicsock_test.go:1138: SendPacket sent
    magicsock_test.go:1144: missing any connection to [{Unknown 1.0.0.2:0 127.0.0.1:43765} {Unknown 1.0.0.2:0 127.3.3.40:1}] from []
--- FAIL: TestTwoDevicePing/ping_1.0.0.2_via_SendPacket (0.00s)
bradfitz added a commit that referenced this issue Apr 18, 2024
@bradfitz
wgengine/magicsock: disable portmapper in tunchan-faked tests
febf5de 
Most of the magicsock tests fake the network, simulating packets going
out and coming in. There's no reason to actually hit your router to do
UPnP/NAT-PMP/PCP during in tests. But while debugging thousands of
iterations of tests to deflake some things, I saw it slamming my
router. This stops that.

Updates #11762

Change-Id: I59b9f48f8f5aff1fa16b4935753d786342e87744
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Apr 18, 2024
Merged
bradfitz added a commit that referenced this issue Apr 18, 2024
@bradfitz
wgengine/magicsock: disable portmapper in tunchan-faked tests
03d5d1f 
Most of the magicsock tests fake the network, simulating packets going
out and coming in. There's no reason to actually hit your router to do
UPnP/NAT-PMP/PCP during in tests. But while debugging thousands of
iterations of tests to deflake some things, I saw it slamming my
router. This stops that.

Updates #11762

Change-Id: I59b9f48f8f5aff1fa16b4935753d786342e87744
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradfitz