Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tstest/integration: TestAddPingRequest flakes #2079

Closed
bradfitz opened this issue Jun 8, 2021 · 1 comment
Closed

tstest/integration: TestAddPingRequest flakes #2079

bradfitz opened this issue Jun 8, 2021 · 1 comment
Assignees
@simenghe
Labels
T7 Build/test failure Issue type

Comments

@bradfitz
Copy link
Member

bradfitz commented Jun 8, 2021

The new TestAddPingRequest flakes sometimes, e.g. with:

$ go test -v -race  -count=5 ./tstest/integration/
...
--- PASS: TestNodeAddressIPFields (9.85s)
=== CONT  TestAddPingRequest
    integration_test.go:266: didn't get PingRequest from tailscaled
    stuntest.go:64: STUN server shutdown
--- FAIL: TestAddPingRequest (21.67s)

@simenghe, can you take a look?
@simenghe simenghe linked a pull request Jun 9, 2021 that will close this issue
tstest/integration: fix TestAddPingRequest flaking #2088
Closed
bradfitz added a commit that referenced this issue Jun 10, 2021
@bradfitz
tstest/integration: add some debugging for TestAddPingRequest flakes
0affcd4 
This fails pretty reliably with a lot of output now showing what's
happening:

TS_DEBUG_MAP=1 go test --failfast -v -run=Ping -race -count=20 ./tstest/integration --verbose-tailscaled

I haven't dug into the details yet, though.

Updates #2079
@bradfitz
Copy link
Member Author

@simenghe, see the 0affcd4 that I just pushed, including its commit message with details of how I was debugging.

That might help you see what's happening.

I can spend some more time on it tomorrow probably.

DentonGentry added a commit that referenced this issue Jun 14, 2021
@DentonGentry
tstest: disable TestAddPingRequest
311ca54 
Failing often now, we don't want people to get used to
routinely ignoring test failures.

Can be re-enabled when
#2079
is resolved.

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
@DentonGentry DentonGentry mentioned this issue Jun 14, 2021
Merged
DentonGentry added a commit that referenced this issue Jun 15, 2021
@DentonGentry
tstest/integration: disable TestAddPingRequest
21dc80d 
Failing often now, we don't want people to get used to
routinely ignoring test failures.

Can be re-enabled when
#2079
is resolved.

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
DentonGentry added a commit that referenced this issue Jun 15, 2021
@DentonGentry
tstest/integration: disable TestAddPingRequest
c61d777 
Failing often now, we don't want people to get used to
routinely ignoring test failures.

Can be re-enabled when
#2079
is resolved.

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
bradfitz added a commit that referenced this issue Jun 15, 2021
@bradfitz
tailcfg, control/controlclient: clarify more, enforce PingRequest.URL…
333e9e7 
… is unique

Updates #2079

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simenghe simenghe

Labels
T7 Build/test failure Issue type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tstest/integration: fix TestAddPingRequest flaking tailscale/tailscale
2 participants
@bradfitz @simenghe