-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android F-Droid build is failing #2536
Comments
I believe pipefail is a bash feature. Is it running under a different shell? |
Apparently, probably dash. We've been setting pipefail in tailscale-version.sh since 10/2020, while the F-Droid build started failing in June. Either the pipefail error is harmless, or something changed in the F-Droid CI. I think we'll fix it anyway, though. |
Forked F-Droid's fdroiddata repo on GitLab, we can see the CI output now https://gitlab.com/DentonGentry/fdroiddata/-/jobs/1459019935
|
I think it is looking for metadata/com.tailscale.ipn/signatures/1.12.1-1d7592eb117-g1fc94ccf979/* |
Oh: this is likely because I'm running the CI in my fork, which of course won't have the signing keys. Shoot. |
We specify `set -o pipefail`, which is not implemented in dash or a number of other shells. The F-Droid builder is defaulting to a shell which does not: ``` ./version/tailscale-version.sh: 10: set: Illegal option -o pipefail ``` Updates tailscale/tailscale#2536 Signed-off-by: Denton Gentry <dgentry@tailscale.com>
I think tailscale/tailscale-android@67c2869 is likely to fix this. I'm expecting to build another 1.13.x unstable release tomorrow, after tailscale/tailscale-android#17 does in, which will trigger another F-Droid build. We'll see. |
We just pushed tailscale/tailscale-android@3575ef7, for 1.13.19-td37451bac-g82b6b8dbd36, which will kick off a new F-Droid build sometime in the next 24 hours, whenever the bot notices. It has not noticed yet: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.tailscale.ipn.yml |
FDroidbot noticed the 1.13.19-td37451bac-g82b6b8dbd36 update about an hour ago: https://f-droid.org/en/packages/com.tailscale.ipn/ Unfortunately https://f-droid.org/en/packages/com.tailscale.ipn/ still shows 1.11.106 as the current version. |
I asked for help from F-Droid: https://gitlab.com/fdroid/fdroiddata/-/issues/2446 |
F-Droid developers responded quickly on the issue: the builder has a large backlog. It isn't that our builds are failing, it is that the builder is behind. It sounded like something happened that slowed it or stopped it for a few days, so now it has to churn through extra work to catch up. There are two issues in the build scripts printing errors which I'll fix, but those errors aren't causing the build to fail just complaining during the build. Yesterday the F-Droid builder released Version 1.11.151-d145c594ad6-g7b2e61e80cd. We'll just monitor it for a while as it progresses. |
1.13.19 is available at https://f-droid.org/en/packages/com.tailscale.ipn/ |
Release 60, 1.13.53-t8bdf87883-g30324736c98 available for download: https://f-droid.org/en/packages/com.tailscale.ipn/ |
Forking the project and running the GitLab CI, the failure is:
./version/tailscale-version.sh: 10: set: Illegal option -o pipefail
The text was updated successfully, but these errors were encountered: