cmd/tsconnect: list of SSH peers is slow to get populated #5273
Assignees
Labels
Comments
mihaip
added a commit
that referenced
this issue
Aug 4, 2022
Reduces the amount of boilerplate to render the UI and makes it easier to respond to state changes (e.g. machine getting authorized, netmap changing, etc.) Preact adds ~13K to our bundle size (5K after Brotli) thus is a neglibible size contribution. We mitigate the delay in rendering the UI by having a static placeholder in the HTML. Required bumping the esbuild version to pick up evanw/esbuild#2349, which makes it easier to support Preact's JSX code generation. Fixes #5137 Fixes #5273 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this issue
Aug 9, 2022
Reduces the amount of boilerplate to render the UI and makes it easier to respond to state changes (e.g. machine getting authorized, netmap changing, etc.) Preact adds ~13K to our bundle size (5K after Brotli) thus is a neglibible size contribution. We mitigate the delay in rendering the UI by having a static placeholder in the HTML. Required bumping the esbuild version to pick up evanw/esbuild#2349, which makes it easier to support Preact's JSX code generation. Fixes #5137 Fixes #5273 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We only send the netmap to JS if we're in the "running" state (c06758c#diff-17cfb2d953cf64e47108124d3599ce9db769412392ea9a7af931d3aa906b8183R181) to avoid showing an empty list while waiting for machine authorization. However, depending on how the netmap vs. state change callbacks happen, we may drop a populated netmap on the floor.
We should hold on to all netmap updates, and only control UI visibility based on the state (switching the UI to Preact #5137 would make this easier).
The text was updated successfully, but these errors were encountered: