Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Go 1.20's strings.CutPrefix, CutSuffix #5309

Closed
bradfitz opened this issue Aug 5, 2022 · 1 comment
Closed

use Go 1.20's strings.CutPrefix, CutSuffix #5309

bradfitz opened this issue Aug 5, 2022 · 1 comment
Labels
future-go

Comments

@bradfitz
Copy link
Member

bradfitz commented Aug 5, 2022

(In 6 months, when Go 1.20 is out)
@bradfitz
Copy link
Member Author

bradfitz commented Aug 5, 2022

Upstream is golang/go#42537

bradfitz added a commit that referenced this issue Aug 5, 2022
@bradfitz
util/strs: add new package for string utility funcs
fa96e86 
Updates #5309

Change-Id: I677cc6e01050b6e10d8d6907d961b11c7a787a05
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Aug 5, 2022
Merged
bradfitz added a commit that referenced this issue Aug 5, 2022
@bradfitz
util/strs: add new package for string utility funcs
01e8ef7 
Updates #5309

Change-Id: I677cc6e01050b6e10d8d6907d961b11c7a787a05
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Aug 5, 2022
@bradfitz
hostinfo, net/netcheck: use CutPrefix
46d7afa 
Updates #5309

Change-Id: I37e594cfd245784bf810c493de68a66d3ff20677
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Aug 5, 2022
Merged
bradfitz added a commit that referenced this issue Aug 5, 2022
@bradfitz
hostinfo, net/netcheck: use CutPrefix
de1594b 
Updates #5309

Change-Id: I37e594cfd245784bf810c493de68a66d3ff20677
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Aug 5, 2022
@bradfitz
hostinfo, net/netcheck: use CutPrefix
ec9d13b 
Updates #5309

Change-Id: I37e594cfd245784bf810c493de68a66d3ff20677
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
mihaip added a commit that referenced this issue Nov 18, 2022
@mihaip
all: use strs.CutPrefix and strs.CutSuffix more
75074f3 
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.

Updates #5309

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
@mihaip mihaip mentioned this issue Nov 18, 2022
Merged
mihaip added a commit that referenced this issue Nov 18, 2022
@mihaip
all: use strs.CutPrefix and strs.CutSuffix more
b236585 
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.

Updates #5309

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip added a commit that referenced this issue Nov 18, 2022
@mihaip
all: use strs.CutPrefix and strs.CutSuffix more
b3c29db 
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.

Updates #5309

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip added a commit that referenced this issue Nov 21, 2022
@mihaip
all: use strs.CutPrefix and strs.CutSuffix more
f79c102 
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.

Updates #5309

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip added a commit that referenced this issue Nov 21, 2022
@mihaip
all: use strs.CutPrefix and strs.CutSuffix more
3352092 
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.

Updates #5309

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
2a33ca3 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Feb 1, 2023
Merged
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
c759e89 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
e6a26e9 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
b787e2c 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
a1f5550 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
7834173 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
6806776 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
1788669 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
307b848 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 1, 2023
@bradfitz
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
b124844 
Updates #7123
Updates #5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz closed this as completed Feb 2, 2023
coadler pushed a commit to coder/tailscale that referenced this issue Feb 2, 2023
@mihaip @coadler
all: use strs.CutPrefix and strs.CutSuffix more
7229b53 
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.

Updates tailscale#5309

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
coadler pushed a commit to coder/tailscale that referenced this issue Feb 2, 2023
@bradfitz @coadler
all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork
44713f1 
Updates tailscale#7123
Updates tailscale#5309

Change-Id: I90bcd87a2fb85a91834a0dd4be6e03db08438672
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future-go
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradfitz